Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Nov 13, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on refactoring and consolidating the CodeSegment component and its related types, moving them from contract-tabs to blocks. It also introduces a new structure for handling code environments and snippets.

Detailed summary

  • Deleted types.ts and CodeSegment.tsx from contract-tabs.
  • Added CodeSegment and CodeEnvironment types in blocks/code-segment.client.tsx.
  • Updated imports across multiple files to reference the new CodeSegment and CodeEnvironment.
  • Enhanced the CodeSegment component to manage code snippets for different environments.
  • Updated story for CodeSegment to include various UI modes and examples.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 7:32pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 13, 2024 7:32pm
thirdweb_playground ⬜️ Skipped (Inspect) Nov 13, 2024 7:32pm
wallet-ui ⬜️ Skipped (Inspect) Nov 13, 2024 7:32pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 13, 2024 14:43 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 13, 2024 14:43 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Nov 13, 2024

⚠️ No Changeset found

Latest commit: 9ea155e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – docs-v2 November 13, 2024 14:43 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 13, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 13, 2024
@MananTank MananTank marked this pull request as ready for review November 13, 2024 14:43
Copy link
Member Author

MananTank commented Nov 13, 2024

@codecov
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.52%. Comparing base (fae444d) to head (9ea155e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5407   +/-   ##
=======================================
  Coverage   45.52%   45.52%           
=======================================
  Files        1070     1070           
  Lines       55665    55665           
  Branches     4030     4030           
=======================================
  Hits        25341    25341           
  Misses      29637    29637           
  Partials      687      687           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from fae444d
packages 40.62% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.8 KB (0%) 896 ms (0%) 188 ms (-41.53% 🔽) 1.1 s
thirdweb (cjs) 105.11 KB (0%) 2.2 s (0%) 658 ms (+38.07% 🔺) 2.8 s
thirdweb (minimal + tree-shaking) 5.72 KB (0%) 115 ms (0%) 97 ms (+715.45% 🔺) 212 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 68 ms (+343.96% 🔺) 78 ms
thirdweb/react (minimal + tree-shaking) 18.78 KB (0%) 376 ms (0%) 163 ms (+412.27% 🔺) 539 ms

@MananTank MananTank force-pushed the 11-13-migrate_codesegment_to_shadcn_tailwind_improved_ui branch from a97160f to 96bdc5a Compare November 13, 2024 14:49
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 13, 2024 14:49 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 13, 2024 14:49 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 13, 2024 14:49 Inactive
@MananTank MananTank force-pushed the 11-13-migrate_codesegment_to_shadcn_tailwind_improved_ui branch from 96bdc5a to 3706d1f Compare November 13, 2024 16:31
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 13, 2024 16:31 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 13, 2024 16:31 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 13, 2024 16:31 Inactive
@gregfromstl gregfromstl changed the title Migrate CodeSegment to shadcn/tailwind + Improved UI [Dashboard] Refactor: Migrate CodeSegment to shadcn/tailwind + Improved UI Nov 13, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 13, 2024

Merge activity

…ed UI (#5407)

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on refactoring the code related to `CodeSegment` and `CodeEnvironment`, moving them to a new location and updating their usage across various components. It also introduces a new `CodeSegment` component with improved functionality.

### Detailed summary
- Deleted `types.ts` and `CodeSegment.tsx` from `contract-tabs`.
- Introduced `CodeSegment` and `CodeEnvironment` in `code-segment.client.tsx`.
- Updated imports in multiple files to use the new `CodeSegment` and `CodeEnvironment`.
- Enhanced `CodeSegment` to manage code snippets for different environments.
- Added stories for `CodeSegment` in `code-segment.stories.tsx`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 11-13-migrate_codesegment_to_shadcn_tailwind_improved_ui branch from 3706d1f to 9ea155e Compare November 13, 2024 19:21
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 13, 2024 19:22 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 13, 2024 19:22 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 13, 2024 19:22 Inactive
@graphite-app graphite-app bot merged commit 9ea155e into main Nov 13, 2024
32 checks passed
@graphite-app graphite-app bot deleted the 11-13-migrate_codesegment_to_shadcn_tailwind_improved_ui branch November 13, 2024 19:33
@vercel vercel bot temporarily deployed to Production – docs-v2 November 13, 2024 19:34 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 13, 2024 19:34 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui November 13, 2024 19:34 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants